Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .vsconfig #56339

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Fix .vsconfig #56339

merged 2 commits into from
Jul 27, 2021

Conversation

danmoseley
Copy link
Member

Importing the .vsconfig in our repo was causing VS to install an older CRT. We need the newer one to avoid

https://developercommunity.visualstudio.com/t/vs2019-lnk2046-and-lnk2047-reported-when-static-li/1306948
thanks @janvorli for the clue

Mostly moves are caused by VS. I left them in the hope there is some opaque stable sort behind them. Also removed the old targeting packs that VS2022 doesn't support.

Verified both are ingested by VS2019 and VS2022 happily.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@danmoseley
Copy link
Member Author

PR validation is messed up. but this file is not used in build or tests.

@danmoseley danmoseley merged commit 4143ac3 into dotnet:main Jul 27, 2021
@danmoseley danmoseley deleted the fixvsconfig branch July 27, 2021 01:30
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants